Hi Tim,<br>Thank you a lot for your fast response and detailed answer. It is great.<br><br><div class="gmail_quote">On Mon, Jun 9, 2008 at 3:40 PM, Tim Niemueller <<a href="mailto:tim@niemueller.de" target="_blank">tim@niemueller.de</a>> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">...<div><br>
</div>Great! I've compiled the package and got some errors:<br>
<br>
- Unpackaged file /usr/bin/rcssmonitor3D-lite, after adding this to the<br>
%files section I could build it.</blockquote><div>Oh, Thanks! Since I don't have freeglut-devel installed, this file wasn't produced on my system. This file isn't useful now and I'll remove it in the %install section. <br>
<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- The devel packages triggers rpmlint warnings which have to be fixed:<br>
# rpmlint rcssserver3d-devel-0.5.9-1.fc9.x86_64.rpm<br>
rcssserver3d-devel.x86_64: W: no-documentation<br>...<br>/usr/lib64/rcssserver3d/libtinyxml.so libtinyxml.so.0.0.0<br>
rcssserver3d-devel.x86_64: W: dangling-relative-symlink<br>...<br>
rcssserver3d-devel.x86_64: E: only-non-binary-in-usr-lib</blockquote><div>Would you please help me a little:<br>1. There are some documentation for developers, but since they're a little big, I prefer to package them in a separate package. (They will double the package size). However there are some HTML pages which I can put here as documentation (I wanted to put them in the doc package). Is it necessary to have some doc files?!<br>
<br>2. What should I do with dangling-relative-symlink warning? The symlinks are valid, but the targets are in the main package. I don't know what should I do to prevent these warnings :( What can I do?<br><br>3. I should go home and check it again, but I think there are only some symlinks in /usr/lib. What's the problem? I don't know what else should be in this directory as other files should be in the main package.<br>
<br><br></div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- You should consider splitting the patch in one GCC4.3 and one rpath patch<br>
<br>
- You are a rcssserver3d committer, right? So why not commit the fixes<br>
and build a package from SVN?<br>
<br>
- The patches seem to contain changes besides fixing rpath and GCC 4.3,<br>
are these changes necessary? Should be a separate patch then.</blockquote><div> </div><div>In fact, I first committed these change to rcssserver3d's CVS and then created the patches using that. This is why all of the patches are in a single file. <br>
Yes, I personally prefer to create a package from CVS, but since one of the review requirement was to compare the package's sources MD5 with upstream release, I thought that I can't build a package from CVS. What should I include in my review request if I build a package from the CVS code? <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- The explicit requires on the libraries shouldn't be necessary,<br>
rpmbuild should be able to figure them out automatically</blockquote><div>I was forced to add them for SUSE Build Service. Is there any need to remove them?<br> <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- What do you mean by comment 4, the "included some so files". What are<br>
these .so files? If these libraries are part of rcssserver3d they should<br>
be added! I don't really understand what you mean I think.</blockquote><div>Sorry for this ambiguity. It is stated in Fedora packaging guidelines that when a package includes versioned .so files, the .so symlinks must go in the -devel package. But I can't do that since the server's binary looks for these .so files. This is why only a few of .so files are in the -devel package.<br>
<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I haven't done any runtime tests.</blockquote><div>At least, they work on my system. <br><br>Thanks again,<br>Hedayat<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Jeff, can I do the review and you sponsor him or do you need to do the<br>
review then as well (I can't sponsor).<br>
<br>
Tim<br>
<br>
--<br>
Tim Niemueller <<a href="mailto:tim@niemueller.de" target="_blank">tim@niemueller.de</a>> <a href="http://www.niemueller.de" target="_blank">www.niemueller.de</a><br>
=================================================================<br>
Imagination is more important than knowledge. (Albert Einstein)<br>
<br>
_______________________________________________<br>
Fedora-robotics-list mailing list<br>
<a href="mailto:Fedora-robotics-list@redhat.com" target="_blank">Fedora-robotics-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/fedora-robotics-list" target="_blank">https://www.redhat.com/mailman/listinfo/fedora-robotics-list</a><br>
</blockquote></div><br>