<div dir="ltr"><div class="gmail_extra">We do not have any guide at the moment but..</div><div class="gmail_extra">I'm trying to address this problem with this PR in help repo:</div><div class="gmail_extra"><br><a href="https://github.com/fheng/help/pull/261">https://github.com/fheng/help/pull/261</a><br><br>Feel free to add some comments and your suggestions.</div><div class="gmail_extra"><br>Regards</div><div class="gmail_extra"><br>Wojtek T.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 17, 2016 at 8:11 PM, Daniel Passos <span dir="ltr"><<a href="mailto:dpassos@redhat.com" target="_blank">dpassos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">There is an option on Github to receive an email for every new PR. I think you can configure it for all repo or only for the repos you want. <br></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, Nov 17, 2016 at 6:05 PM, Martin Murphy <span dir="ltr"><<a href="mailto:mmurphy@redhat.com" target="_blank">mmurphy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks Passos.<br>
<br>
That would mean that someone on the team would have to be looking out<br>
for PRs to the open source repos.<br>
Do you know if we have that in place for all our open source repos?<br>
<br>
Cheers,<br>
M.<br>
<div class="m_-4491357476102771933HOEnZb"><div class="m_-4491357476102771933h5"><br>
<br>
On 17 November 2016 at 19:44, Daniel Passos <<a href="mailto:dpassos@redhat.com" target="_blank">dpassos@redhat.com</a>> wrote:<br>
> What we have been doing on AeroGear is:<br>
><br>
> 1) If the PR came from the community?<br>
><br>
> * Check is there is a Jira for this one, if not create one and link the PR<br>
> * Ping someone with more knowledgement about the project to review this one<br>
><br>
> Example: <a href="https://github.com/aerogear/aerogear-ios-http/pull/73" rel="noreferrer" target="_blank">https://github.com/aerogear/ae<wbr>rogear-ios-http/pull/73</a><br>
>                 <a href="https://github.com/aerogear/aerogear-ios-oauth2/pull/61" rel="noreferrer" target="_blank">https://github.com/aerogear/a<wbr>erogear-ios-oauth2/pull/61</a><br>
><br>
><br>
> 2) If the PR came from the team<br>
><br>
> * Add the Jira about the PR in the PR<br>
> * Ping someone with more knowledge about the project to review this one<br>
><br>
> Example: <a href="https://github.com/aerogear/aerogear-android-auth/pull/37" rel="noreferrer" target="_blank">https://github.com/aerogear/ae<wbr>rogear-android-auth/pull/37</a><br>
><br>
> Bonus point to comment using reaction gifts[1]<br>
><br>
> [1] <a href="http://www.reactiongifs.com/" rel="noreferrer" target="_blank">http://www.reactiongifs.com/</a><br>
><br>
><br>
> On Thu, Nov 17, 2016 at 5:23 PM, Martin Murphy <<a href="mailto:mmurphy@redhat.com" target="_blank">mmurphy@redhat.com</a>> wrote:<br>
>><br>
>> How are PRs to open source repos reviewed?<br>
>> e.g. if someone submits a PR for fh-fhc, is that enough to get a review?<br>
>> Or do they have to ping someone/someplace?<br>
>><br>
>> Cheers,<br>
>> M.<br>
>><br>
>> ______________________________<wbr>_________________<br>
>> feedhenry-dev mailing list<br>
>> <a href="mailto:feedhenry-dev@redhat.com" target="_blank">feedhenry-dev@redhat.com</a><br>
>> <a href="https://www.redhat.com/mailman/listinfo/feedhenry-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/feedhenry-dev</a><br>
><br>
><br>
><br>
><br>
> --<br>
> -- Passos<br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-4491357476102771933gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- Passos<br></div></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
feedhenry-dev mailing list<br>
<a href="mailto:feedhenry-dev@redhat.com">feedhenry-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/feedhenry-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/feedhenry-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div style="font-size:12.8px"><span style="color:rgb(153,153,153);font-size:small">Wojciech Trocki</span></div><div><div><font color="#999999" size="2">Software Engineer</font><font color="#999999" style="font-size:small">, Red Hat Mobile</font></div><div><div style="font-size:small"><br></div><div style="font-size:small"><img src="cid:1deff70600823b9ebf187fa9e94df6ff10966d4e@zimbra"></div></div></div></div></div></div></div>
</div>