[PATCH] Re: [Freeipa-devel] Suggest install not overwrite /etc/ipa/ipa.conf
Karl MacMillan
kmacmill at redhat.com
Fri Aug 3 14:30:52 UTC 2007
On Thu, 2007-08-02 at 13:47 -0700, Kevin McCarthy wrote:
> I just spent a little time trying to figure out why my xmlrpc calls
> broken suddenly. It turns out I forgot that redoing a 'make install'
> will overwrite the ipa.conf file. We may want to consider whether it's
> a good idea to do this. It certainly can be inconvient to remember to
> re-edit the conf file each time.
>
Just committed the patch below to implement this suggestion.
[?1034h# HG changeset patch
# User "Karl MacMillan <kmacmillan at mentalrootkit.com>"
# Date 1186151279 14400
# Node ID ae9112b5c733c14a04077d02bc6a50544e4a0901
# Parent b1d8edff7ea26807d8d61e442019a642e0498819
Only install the ipa.conf file if it does not exist.
diff -r b1d8edff7ea2 -r ae9112b5c733 ipa-python/Makefile
--- a/ipa-python/Makefile Thu Aug 02 14:15:40 2007 -0700
+++ b/ipa-python/Makefile Fri Aug 03 10:27:59 2007 -0400
@@ -8,7 +8,10 @@ install:
-mkdir -p $(PACKAGEDIR)
install -m 644 *.py $(PACKAGEDIR)
-mkdir -p $(CONFIGDIR)
- install -m 644 ipa.conf $(CONFIGDIR)
+ if ! [ -e $(CONFIGDIR)/ipa.conf ]; then \
+ install -m 644 ipa.conf $(CONFIGDIR); \
+ fi
clean:
- rm -f *~ *.pyc
\ No newline at end of file
+ rm -f *~ *.pyc
+
More information about the Freeipa-devel
mailing list