[Freeipa-devel] [PATCH] fix user.getValue()

[Andrew Bartlett]

On Mon, 2007-08-13 at 09:31 -0400, Rob Crittenden wrote:
> Kevin McCarthy wrote:
> > I think we should be looking at the value instead of value[0] to
> > determine what it is.  I stumbled across this bug because I was able to
> > submit telephoneNumber as an empty string.  The code was blowing up
> > trying to do a value[0] on "".
> > 
> > This raises a point about whether we should allow empty strings into
> > LDAP.  Pete had some points about this, but I'll allow him to state them
> > (since I'm not sure I understood them).
> > 
> > -Kevin
> 
> I suspect that the proper fix is to not allow empty attributes to be set 
> in the first place.

Empty attributes sounds like a route to pain...  Also perhaps ensure
admins can't set an attribute to " ". 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070814/de3480ec/attachment.sig>