[Freeipa-devel] [PATCH] Update of update

[Rob Crittenden]

Kevin McCarthy wrote:
> Kevin McCarthy wrote:
>> Rob Crittenden wrote:
>>> Pull some of the logic into the server-side. Change update_user to take a 
>>> User object and do the conversion to a dict internally instead.
>>>
>>> Don't allow the User object to use __setattr__ except for dn and data. We 
>>> want them to use setValue() or setValues() so the cidict is used.
>>>
>>> The ipa-usermod tool is updated to use the new API.
>> Rob and I discussed this over IRC.  This introduces a subtle change in
>> how updates work - old unchanged values will end up overwriting a value
>> someone else may have updated "in the middle".
>>
>> I'm going to take a different shot at this and post a patch for this.
> 
> This is almos the same as Rob's patch, but just changes it to cache the
> original values when the user is instantiated.
> 
> If this looks good, I'd like the pull the utf-8 conversion inside the
> user object and then change add_user() to take a user object parameter
> too.
> 
> -Kevin
> 
>

+1

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070820/55add49d/attachment.bin>