[Freeipa-devel] [PATCH] enhanced user search

[Rob Crittenden]

Rob Crittenden wrote:
> Kevin McCarthy wrote:
>> Enhanced user search:
>> - "configurable" fields to search on  (this is hardcoded but can be
>>   moved to the external configuration easily)
>> - tokenize search words
>> - prioritize exact matches over partial matches
>> Other updates:
>> - use finally block to return ldap connections
>> - update web gui to use new get_user methods
> 
> We will need to do searches of groups as well. Can you break out the 
> search_pattern-creation code block into a function?
> 
> Do we want to do any approximate searching (=~)?
> 
> What implication does this have if I know the entry I want.
> 
> What I mean is that I want to bring up the record for 'rcrit' so I do a 
> search on it and I'd like it to just pop up that record since I have an 
> exact match on it. What happens if there is a jrcritenham too? That 
> record is going to pop up as well because of the partial searches.
> 
> I see why you drop "*" from user input but will that make users mad?
> 
> This is, of course assuming that if only one record is found rather than 
> displaying a list of users, that user's record is brought up. Not sure 
> that is the right thing to do either.
> 
> The code generally looks good. We can always just stick it in and see if 
> it annoys us too much :-)
> 
>

As I thought about this more perhaps we should pass in some flags 
outlining how the search should work. Exact match, partial match, etc...

This gives the client implementor control.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070824/b20c8599/attachment.bin>