[Freeipa-devel] [PATCH] fix errors with CalledProcessError

[Rob Crittenden]

Karl MacMillan wrote:
> On Tue, 2007-12-04 at 15:09 -0500, Rob Crittenden wrote:
>> Karl MacMillan wrote:
>>> On Tue, 2007-12-04 at 10:52 -0500, Rob Crittenden wrote:
>>>> Karl MacMillan wrote:
>>>>> The conversion to a single CalledProcessError had some mistakes - this
>>>>> fixes those.
>>>>>
>>>>> Karl
>>>> Did it not work for you?
>>>>
>>> No - dsinstance.py only has:
>>>
>>> from ipa.ipautil import *
>>>
>>> So we would need to add
>>>
>>> from ipa import ipautil
>>>
>>>> I had the explicit references to ipautil so people wouldn't get confused 
>>>> that it was calling subprocess.
>>>>
>>> I can switch to this if you would prefer.
>>>
>>> Karl
>>>
>> I would, but I'm a neophyte python guy, so whatever people typically do 
>> I'm fine with. But since we're subclassing a function using the same 
>> name it seemed best to be clear about it.
>>
> 
> Updated patch attached - I didn't want to use functions from ipautil in
> two ways, so everything is accessed through ipautil.
> 
> BTW - if people haven't found it pychecker works well when doing these
> kinds of things.

Acked and pushed.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071205/fdcd83e9/attachment.bin>