[Freeipa-devel] [PATCH] Initial Radius Work

[Karl MacMillan]

On Sat, 2007-11-03 at 13:59 -0400, John Dennis wrote:
> Attached are 3 mercurial changesets that comprise the initial work to 
> integrate freeradius with IPA, please review.
> 
> Question: It would be easier to review the patch if the diffs were 
> cumulative rather than sequential (the last two changesets were minor 
> issues discovered during a test install). Is there a way to get mecurial 
> to roll up all the changes in a revision range into one diff? I couldn't 
> figure out how to do it.
> 

You can either just use hg diff specifying multiple revisions or - what
I recommend - use mercurial patch queues. 

http://www.selenic.com/mercurial/wiki/index.cgi/MqExtension

> Note: This comprises only the IPA source changes. There is also a 
> significant change to the freeradius package in order to work with IPA. 
> Sometime soon I'll build and post a new freeradius rpm. I wanted to get 
> these initial changes out first for review ASAP.

I went ahead and pulled in these changes to help with the merging of
some other patches. A few comments:

1) Simo / Pete - can you please review the schema added.
2) What's is get_rpm_nvr_by_name used for? So far we have no explicit
rpm deps in the code - I would very much like to keep it that way.

Karl