[Freeipa-devel] [PATCH] Multi-valued field support

Rob Crittenden rcritten at redhat.com
Fri Nov 9 16:24:48 UTC 2007


Karl MacMillan wrote:
> On Thu, 2007-11-08 at 22:15 -0500, Rob Crittenden wrote:
>> This patch enables multi-value field support for some attributes on the 
>> edit pages (not the new pages). I punted on new because multiple values 
>> on the cn makes doing auto-suggest trickier. I'll come back to it.
>>
>> I improved error reporting in the GUI by printing the LDAP message as well.
>>
>> I also wrote up a short document describing how multi-valued fields work 
>> (so I don't forget later).
>>
> 
> I reviewed this as well as I could and it looks ok. Should we push the
> config of which fields are multi-valued into ldap - whenever the ldap
> config gets done - or should we just leave them hard coded?

No. If we used the standard TG template system we might be able to but 
currently the UI is hardcoded (so we have more control).

> 
>> Also attached is a required SRPM of the new widget. This RPM just 
>> re-packages an already packaged file. TG uses "egg" format for 
>> distributing stuff (zip file basically). My RPM just moves data around.
> 
> So this will be a separate rpm that we distribute? Or is this general
> enough that we should push it to Fedora? Or should we just push this
> widget into the ipa-server rpm?

Ah, I suppose we could submit it to Fedora...

For now I was thinking we'd carry it. I thought about including it in 
the main source but was thinking that it would make discrete upgrading 
difficult.

> I'm thinking that we need to start version controlling all of the rpms
> that we may have to ship. Anyone have thoughts on this? Same repo as the
> rest of freeipa or a separate repo?
> 
> I'll push this as soon as I understand how this should work.

The risk of including it in the freepia repo is that if we include a 
large rpm package it could make source pulls a pain. Right now the code 
is very small which is nice.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071109/584cc4d2/attachment.bin>


More information about the Freeipa-devel mailing list