[Freeipa-devel] [PATCH]

[Simo Sorce]

On Fri, 2007-11-16 at 23:26 -0500, Rob Crittenden wrote:
> Simo Sorce wrote:
> > Lots of fixes for the password change plugin.
> > Added userPassword support for simple binds.
> > and password history support.
> > Also make it retrieve the Master Key from ldap.
> 
> In this change did you mean to have for (i = 0i ... ?
> 
> @@ -248,7 +263,7 @@ static Slapi_Value **encrypt_encode_key(
>   			kbvals = (struct kbvals *)calloc(count, sizeof(struct kbvals));
>   		}
>   		n = 0;
> -		for (i = 0; count > 0 && i < count; i++) {
> +		for (i = 0i, idx = 0; count > 0 && i < count; i++) {
>   			if (i == 0) {
>   				idx = slapi_valueset_first_value(svs, &sv);
>   			} else {

Wow, and this compiled too ... It was not intended of course, just a
"vi" editor common typo :(

> Lots of other slapi code I sort of follow and didn't see anything 
> obviously wrong. So ok.

Thanks.
Simo.

-- 
| Simo S Sorce |
| Sr.Soft.Eng. |
| Red Hat, Inc |
| New York, NY |