[Freeipa-devel] [PATCH] more robust installation error handling

[Karl MacMillan]

On Wed, 2007-10-03 at 17:50 -0400, Rob Crittenden wrote:
> Simo Sorce wrote:
> > On Wed, 2007-10-03 at 16:13 -0400, Rob Crittenden wrote:
> >> This needs more work but it is a first crack at trying to catch more 
> >> error conditions during installation. What it currently lacks is 
> >> completely bailing out, offering the user a choice to continue and/or 
> >> doing a rollback.
> >>
> >> I also didn't add any code to exit out if an existing DS is found.
> >> Not 
> >> sure if we want to do that or not.
> >>
> >> I also incorporated most of the patch to handle when SELinux is
> >> disabled 
> >> from Jon McCann. I just do the selinux check slightly differently.
> >>
> >> I also noticed an error when I had old service keytabs and included 
> >> something to handle SASL/GSSAPI authentication failures when getting
> >> a 
> >> connection. 
> > 
> > 
> > Looks very good.
> >
> 
> Pushed. The patch I pushed out removes the selinux test that Jon added 
> and replaces it with one that uses /usr/sbin/selinuxenabled to determine 
> if SELinux is available or not.

Either one is likely fine, but I think checking for enabled like you do
is preferred. That will allow other errors to crop up (if the policy is
drastically different from expected for example).

Karl