[Freeipa-devel] [PATCH] autotoolize ipa-client

[Rob Crittenden]

William Jon McCann wrote:
> On 10/16/07, Rob Crittenden <rcritten at redhat.com> wrote:
>> William Jon McCann wrote:
>>> Hi
>>>
>>> On 10/16/07, Karl MacMillan <kmacmill at redhat.com> wrote:
>>>> On Fri, 2007-10-12 at 15:09 -0400, William Jon McCann wrote:
>>>>> Hi,
>>>>>
>>>>> Here is a patch to autotoolize ipa-client.
>>>>>
>>>> Any ideas:
>>>>
>>>> $ ./configure
>>>> ./configure: line 1627: AM_INIT_AUTOMAKE: command not found
>>>> ./configure: line 1629: AM_MAINTAINER_MODE: command not found
>>>> configure: Checking for Python
>>>> ./configure: line 1637: syntax error near unexpected token `2.3'
>>>> ./configure: line 1637: `AM_PATH_PYTHON(2.3)'
>>> Did you run autogen.sh?  Strange, this looks like automake is broken
>>> on your system.  Those are all standard macros.
>>>
>>>
>> Along these lines, I wonder if we need separate autoconf configurations
>> for each subdirectory. What do other large services do that include a
>> client and a server (Samba for example, or openldap)?
> 
> It is usually based on how you package it.  There is usually one
> configure script per package: ipa-client, ipa-server, ipa-python, etc.

I'm not so sure about that and I think it would cause confusion (e.g. 
oops, forgot to use --prefix in one of the builds). I'm with John Dennis 
on this, one configure.ac to rule them all.

> 
>> I've gone through the server one a bit and found a few problems, not
>> necessarily with the autoconf code but with some hardcoded directories.
> 
> Like what?

ipa.conf for one (the file for Apache). Would need an ipa.conf.in instead.

>> Also, make dist-clean still leaves a slew of autoconf-generated files. I
>> think we should have a make target that removes everything
>> auto-generated, if not dist-clean then something else. Or we can leave
>> them around as most projects do, but we should decide now.
> 
> distclean is supposed to leave those files.  It should only clean up
> what configure makes:
> http://www.gnu.org/software/automake/manual/html_node/Clean.html
> 
> In practice, the maintainer-clean target has been extended to
> additionally clean files generated by autogen.sh.

Ok, maintainer-clean is a lot better! I use 'hg stat' to make sure I 
don't miss any new files and sifting through all the autoconf cruft 
would be painful at best.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071017/edc6d2d9/attachment.bin>