[Freeipa-devel] [PATCH] Allow set/add/del to be called multiple times

Simo Sorce ssorce at redhat.com
Wed Oct 31 20:46:34 UTC 2007


On Wed, 2007-10-31 at 16:42 -0400, Karl MacMillan wrote:
> On Wed, 2007-10-31 at 16:22 -0400, Simo Sorce wrote:
> > On Wed, 2007-10-31 at 16:00 -0400, Karl MacMillan wrote:
> > > 
> > > Allow the --set/add/del options to be called multiple
> > > times during the same invocation. Also add more robust
> > > checking of errors.
> > 
> > It seem you assume that ',' is a valid separator, but it may well be
> > part of the value instead.
> > You need to use some escaping imo (at the very least "values" in
> > quotes).
> > 
> 
> Since we can call add multiple times, maybe the easiest thing is to stop
> splitting on "," entirely.

agreed

Simo.




More information about the Freeipa-devel mailing list