[Freeipa-devel] [PATCH] small (but important) fixes for release

Kevin McCarthy kmccarth at redhat.com
Fri Sep 7 18:08:21 UTC 2007


Kevin McCarthy wrote:
> Fixes three issues:
> - password isn't mandatory for add person
> - fix for searching on '*' (it blew up)
> - Change my principal to 'admin' until the correct way is sorted out

Rob pointed out his next patch/readme will obviate the needs for
changing the principal.  Here's a revised patch with just the first two
fixes.

-Kevin

-------------- next part --------------
# HG changeset patch
# User Kevin McCarthy <kmccarth at redhat.com>
# Date 1189188479 25200
# Node ID c6f1383b70771d65b315242611d7ae1419aab115
# Parent  31924e58a3c3a0e550d7ebc68c89b03fa1a10f3f
small release fixes:
- Make password not required for add person
- Fix for searching on '*' or ''

diff -r 31924e58a3c3 -r c6f1383b7077 ipa-server/ipa-gui/ipagui/forms/user.py
--- a/ipa-server/ipa-gui/ipagui/forms/user.py	Thu Sep 06 16:21:07 2007 -0700
+++ b/ipa-server/ipa-gui/ipagui/forms/user.py	Fri Sep 07 11:07:59 2007 -0700
@@ -26,8 +26,8 @@ class UserFields():
 
 class UserNewValidator(validators.Schema):
     uid = validators.PlainText(not_empty=True)
-    userpassword = validators.String(not_empty=True)
-    userpassword_confirm = validators.String(not_empty=True)
+    userpassword = validators.String(not_empty=False)
+    userpassword_confirm = validators.String(not_empty=False)
     givenname = validators.String(not_empty=True)
     sn = validators.String(not_empty=True)
     mail = validators.Email(not_empty=True)
diff -r 31924e58a3c3 -r c6f1383b7077 ipa-server/xmlrpc-server/funcs.py
--- a/ipa-server/xmlrpc-server/funcs.py	Thu Sep 06 16:21:07 2007 -0700
+++ b/ipa-server/xmlrpc-server/funcs.py	Fri Sep 07 11:07:59 2007 -0700
@@ -389,7 +389,7 @@ class IPAServer:
         criteria_words = re.split(r'\s+', criteria)
         criteria_words = filter(lambda value:value!="", criteria_words)
         if len(criteria_words) == 0:
-            return []
+            return [0]
 
         (exact_match_filter, partial_match_filter) = self.__generate_match_filters(
                 search_fields, criteria_words)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070907/519776f1/attachment.bin>


More information about the Freeipa-devel mailing list