[Freeipa-devel] [PATCH] a bunch of small tweeks

[Karl MacMillan]

On Thu, 2007-09-27 at 10:45 -0700, Kevin McCarthy wrote:
> Karl MacMillan wrote:
> > On Thu, 2007-09-27 at 10:18 -0700, Kevin McCarthy wrote:
> > > Karl MacMillan wrote:
> > > > On Tue, 2007-09-25 at 11:30 -0700, Kevin McCarthy wrote:
> > > > > This is a set of small tweeks suggested in my meeting with Bob and Pete
> > > > > yesterday.
> > > > > 
> > > > > The most controversial is adding a search timeout for find users and
> > > > > groups.  I've put this at 2 seconds for now.  The problem with this
> > > > > approach is that it makes the number of results that come back random -
> > > > > depending on the server.
> > > > > 
> > > > > So, consider it a test.  Please send your feedback if you have opinions
> > > > > (it's pushed to demo).
> > > > > 
> > > > 
> > > > It looks like the time limit will effect all clients, including xml-rpc
> > > > clients? If so, that doesn't seem like a good idea. Should we expose a
> > > > timeout parameter in the xml-rpc layer and let the gui have a
> > > > configurable value that it always passes?
> > > 
> > > I'm not sure why it matters differently for xml-rpc clients?  The time
> > > limit it on the ldap search operation.  Or, do we expect the xml-rpc
> > > clients to be used more for reporting (in which case I agree it's a
> > > problem).
> > > 
> > 
> > I was thinking that the xml-rpc clients might be used in ways that we
> > don't want the timeout - reporting being a good example.
> 
> Okay, I will add a timeout parameter then, and default it to "no
> timeout".
> 
> I'm buried in the group edit stuff right now, so if you don't mind
> pushing it would work better for me to add that as a separate patch
> later today/tomorrow.  :-)
> 

You got it - pushed.

Karl