[Freeipa-devel] [PATCH] use same regex for user/group names as shadow-utils

Rob Crittenden rcritten at redhat.com
Thu Aug 7 15:23:51 UTC 2008


Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Rob Crittenden wrote:
>> This patch replaces the patch of the same name and the "fix validation
>> return types" patch(es).
>>
>> Turns out my tree was quite a bit out-of-date so I re-based the patches
>> and combined them.
>>
>> The user/group name validator didn't match the standard *nix validator
>> and disallowed some valid names and allowed some invalid ones (including
>> those with spaces).
>>
>> This brings it inline with shadow-utils from Fedora 9.
>>
>> Also change the validation routines to return 0/1 instead of True/False
>> which made readability difficult, particularly with the reversed logic.
>>
>> rob
> 
> ack
>

pushed to master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080807/6639e356/attachment.bin>


More information about the Freeipa-devel mailing list