[Freeipa-devel] [PATCH] Fix versioning stuff in master tree

[Simo Sorce]

On Mon, 2008-08-11 at 17:35 -0400, Rob Crittenden wrote:
> Simo Sorce wrote:
> > On Mon, 2008-08-11 at 16:28 -0400, Rob Crittenden wrote:
> >> Simo Sorce wrote:
> >>> On Fri, 2008-08-08 at 15:41 -0400, Rob Crittenden wrote:
> >>>> Simo Sorce wrote:
> >>>>> Setting version numbers was a bit too much manual, and obviously got out
> >>>>> of sync. ipa-server and ipa-client configure were reporting version
> >>>>> 0.6.0 ...
> >>>>>
> >>>>> This patch fixes some of these spots and also allows for easier control
> >>>>> over RPMs versioning when using make local-dist
> >>>>>
> >>>>> Simo.
> >>>> Bleh, guess I missed a few on the first pass.
> >>> No problem :-)
> >>>
> >>>> I'm not sure I follow the logic of moving the dependency of 
> >>>> version-update to clean/dist-clean. Can you elaborate?
> >>> It creates version.m4
> >>> without it any call to autoconf will fail as configure.ac includes it
> >>>
> >>> Simo.
> >>>
> >> maintainer-clean doesn't clean up a bunch of files used in the versioning:
> >>
> >> #       RELEASE
> >> #       ipa-admintools/ipa-admintools.spec
> >> #       ipa-client/version.m4
> >> #       ipa-radius-admintools/ipa-radius-admintools.spec
> >> #       ipa-radius-server/ipa-radius-server.spec
> >> #       ipa-server/selinux/ipa-server-selinux.spec
> >> #       ipa-server/version.m4
> >>
> >> I'd think we'd want to remove these, right?
> > 
> > maybe but it didn't remove the .spec files before :-)
> > do you want me to add this clean up to this patch ?
> > or should we have a separate patch for that ?
> 
> In my unpatched tree the only file getting left over after a 
> maintainer-clean is ipa-server/selinux/ipa-server-selinux.spec.
> 
> It can be a separate patch.

No, I do not like regressions, here's an updated patch that fixes the
problem, will commit it as the change was trivial and I tested it works.

Simo.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-versioning-for-configure.ac-and-ipa-python-setup.patch
Type: application/mbox
Size: 14577 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080811/32b42d12/attachment.mbox>