[Freeipa-devel] [PATCH] Support password change operation by direct manipulation of userPassword

Simo Sorce ssorce at redhat.com
Tue Aug 12 13:41:02 UTC 2008


On Tue, 2008-08-12 at 08:57 +0200, Martin Nagy wrote:
> Simo Sorce wrote:
> > On Thu, 2008-07-24 at 11:13 -0400, Simo Sorce wrote:
> >> On Wed, 2008-07-23 at 10:20 -0400, Simo Sorce wrote:
> >>> This is an initial patch to support generating kerberos key material
> >>> (and other hashes) when an ldap ADD or MODIFY operation is performed on
> >>> the userPassword attribute.
> >>>
> >>> Basic testing seem to work, but I'd like feedback both on the method
> >>> used and on the implementation. I have probably missed something as I
> >>> had to work on the patch at different times with large intervals between
> >>> each coding session, so please test it if you can before I push it to
> >>> master.
> >> New patch, this incorporate suggestions to create helper functions for
> >> common code and also fixes quite a number of bugs, thanks to Rich for a
> >> quite accurate analysis too.
> > 
> > Another revision, this one removes the requirement to have an ssl
> > connection to just ldapadd/ldapmodify the userPassword attribute.
> > This would be a change in behavior for DS and may cause problems to
> > existing applications.
> > 
> > Simo.
> 
> Simo, your patch uses spaces for intendation, whereas the file uses tabs.

It was intentional.
Given these are new functions I switched to use the official coding
style as per: http://freeipa.org/page/Coding_Style

I intend to slowly convert the rest of the file piece by piece.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list