[Freeipa-devel] [PATCH] tool to manage search and user policy

[Martin Nagy]

Rob Crittenden wrote:
> Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Empty patch
> 
> One of those days.
> 
> rob
> 
> > 
> > Rob Crittenden wrote:
> >> Martin Nagy wrote:
> >>> Rob Crittenden wrote:
> >>>> The CLI had no tool to manage the Search and User policy though
> >>>> the web UI did. This patch adds a new tool to edit these values.
> >>>>
> >>>> rob
> >>> No comments to the name of the utility :)
> >>> Just a very few minor details:
> >>>
> >>> .dotest/patch:176: trailing whitespace.
> >>>     if options.show:
> >>>
> >>>  From ipa-admintools/ipa-policyconfig, function update_policy():
> >>> For some attributes, the minimum of 0 is not appropriate.
> >>> For the string attributes, I'd say specifying min=0 isn't
> >>> required.
> >>>
> >>> Otherwise, the patch seems fine to me.
> >>>
> >>> Martin
> >> I rebased the patch, changed the tool name to ipa-defaultoptions,
> >> fixed the trailing space and the min allowed values.
> >>
> >> rob

Ugh, you still forgot to rename ipa-policyconfig in man/Makefile :)
But ack anyway, just don't forget to change before the push.

Martin