[Freeipa-devel] [PATCH] ipa-getkeytab enhancements

[Simo Sorce]

On Wed, 2008-08-20 at 15:26 +0200, Martin Nagy wrote:
> Simo Sorce wrote:
> > Add 2 linked enhancements to ipa-getkeytab
> > 1. make it possible to use a known password not forcibly a random
> > secret 2. make it possible to specify a salt type along with the
> > encryption type
> > 
> > The server side needn't any modification as it was already built to
> > accept optional salt fields. All seem to work as expected when using
> > the 2 features (note that salts can be used only if a password is
> > specified).
> > 
> > Simo.
> 
> All line numbers refer to the patched ipa-getkeytab.c:
> For the consistency sake, I wouldn't use messages like "Out of
> memory!?\n", I think you should remove the !?.
ack

> Also, you didn't add a
> message on line 169.
ack

> You can remove line 160, it doesn't do anything.
ack

> On line 181 I'd say "encryption type" instead of "enc type".
ah you caught me, I was trying to stay under 80 columns on that line :-P
ack

> Typo on line 283.
ack

> On line 457 I think you meant to write keys[j] = keys[j + 1].
arghh right, how did it work ? :)
ack

> I'm reasonably convinced that the code is good, however I'm not an
> expert on the kerberos or lber functions (although where I could I
> looked at some documentation and source code). So I'd
> say you have a 95% ack from me.

Ok re-sending with the spotted bugs fixed.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York