[Freeipa-devel] [PATCH] more flexible group membership querying

[Simo Sorce]

On Wed, 2008-03-26 at 11:37 -0400, Rob Crittenden wrote:
> +            if e.dn not in real_members:
> +                if membertype == 2:
> +                    entries.append(self.convert_entry(e))
> +            else:
> +                if membertype == 1:
> +                    entries.append(self.convert_entry(e))
> +

Shouldn't the second be a removal ?
You defined 1 as: "only direct members" so indirect ones should be
removed right ?

Also it would be a bit less confusing to use direct_members instead of
real_members, but this is just taste.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York