[Freeipa-devel] [PATCH] Fix mem leaks in password plugin

Nathan Kinder nkinder at redhat.com
Thu Nov 20 23:01:05 UTC 2008


Simo Sorce wrote:
> $subject
>   
Use slapi_ch_free_string() for freeing char * types instead of 
slapi_ch_free() as in your patch.  This lets you avoid an ugly cast to 
void** (which you are missing, and should be getting warning about).

    void slapi_ch_free(void **ptr);
    void slapi_ch_free_string(char **s);

Other than the above, it looks good.
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel




More information about the Freeipa-devel mailing list