[Freeipa-devel] [PATCH] Fix architecture detection in ldapupdate

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Nagy wrote:
> I noticed the architecture detection won't work, since
> platform.platform() will return something like
> 'Linux-2.6.25.14-108.fc9.i686-i686-with-fedora-9-Sulphur'. After the
> patch the detection should be better and we explicitly ask about the
> bits, not just the arch.
> 
> I also did a tiny change in a while loop.
> 
> Martin
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Since I don't know where this return value goes, I want to ask a
question. Is it only the 64-bit nature that matters, or is the x86_64
architecture directly relevant?

In other words, the previous code was checking for x86_64 processors
only, but now you've expanded it to potentially include IA64, Sparc64, etc.

- --

- --------------------
Stephen Gallagher
RHCE 804006346421761
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkjTkCoACgkQc7MaxVic+2pDngCeNuWCSrWIkx6/ItEQpwNf2LYj
xA8An0sVJh+Wyld6snqSqTvGBYOkMumZ
=Pc5U
-----END PGP SIGNATURE-----