[Freeipa-devel] [PATCH] detect when updates are available

Rob Crittenden rcritten at redhat.com
Fri Sep 19 15:22:45 UTC 2008


Martin Nagy wrote:
> Rob Crittenden wrote:
>> Martin Nagy wrote:
>>> Rob Crittenden wrote:
>>>> This patch will cause the test mode to return 2 when updates are 
>>>> available and 0 when they are not.
>>>>
>>>> So when an admin installs a new package they can run 
>>>> /usr/sbin/ipa-ldaper-update -t to determine whether there are
>>>> updates to apply.
>>>>
>>>> rob
>>> Few things I noticed:
>>>
>>>> add:attributeTypes: X-ORIGIN 'RFC2307bis' )
>>>>  add:attributeTypes:
>>>>     ( 1.3.6.1.4.1.1.1.1.12 NAME 'nisDomain'
>>>> -     DESC 'NIS domain' SUP name
>>>> +     DESC 'NIS domain'
>>>>       SYNTAX 1.3.6.1.4.1.1466.115.121.1.26
>>>>       X-ORIGIN 'RFC2307bis' )
>>>>  add:attributeTypes:
>>> Hmm, why are you reverting the previous patch you sent?
>>>
>>>> +        import pprint
>>>> +        f = open('s', 'w')
>>>> +        pprint.pprint(s, f)
>>>> +        f.close()
>>>> +        f = open('n', 'w')
>>>> +        pprint.pprint(n, f)
>>>> +        f.close()
>>>> +
>>>> +        if s == n:
>>>> +            return False
>>>> +        else:
>>>> +            return True
>>> Why are you writing out to those files? They don't seem to be read
>>> later on.
>>>
>>> Martin
>> Updated patch attached
>>
>> rob
> ack

pushed to master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080919/4f42cc4c/attachment.bin>


More information about the Freeipa-devel mailing list