[Freeipa-devel] [PATCH] Fixes for nsssrv service

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simo Sorce wrote:
> On Wed, 2009-04-01 at 10:31 -0400, Stephen Gallagher wrote:
>> Simo Sorce wrote:
>>> This patch contains fixes needed to make LOCAL be backed by
>>> proxy/libnsss_files (ie local /etc/passwd,/etc/group accounts)
>>>
>>> It also fixes various minor issues found while testing it.
>>>
>>> Simo.
>>>
>> No patch attached.
> 
> I am Dumb, du-dumb, du-dumb, da-da ...
> 
> here it is.
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack

Copy-paste error in sysdb.h
- -#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_LAST_UPDATE, \
+#define SYSDB_GRPW_ATTRS {SYSDB_NAME, SYSDB_UIDNUM, \
+                          SYSDB_LAST_UPDATE, \
                           "objectClass", \
                           NULL}

Should be SYSDB_GIDNUM, shouldn't it?

Also, if we're testing for invalid UID/GID, wouldn't '<= 0' be more
accurate than '== 0'?


Nitpick:
+        DEBUG(1, ("The '%s' library does not provides the "
+                  "_nss_XXX_initgroups_dyn function!\n"
+                  "initgroups will be slow as it will require "
+                  "full groups enumeration!\n", libname));

Should read:
The '%s' library does not provide the _nss_XXX_initgroups_dyn function!
initgroups will be slow as it will require full group enumeration.


Nitpick:
Testing for
if ((info->id_min && (gid < info->id_min))
is redundant. We only need to test
if(gid < info->id_min)



- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAknTmA4ACgkQeiVVYja6o6MTBgCff9Luwk+1HYWdBzHnTsMRN2iG
7x8An2vBNnBxiVkY28NHqJuYu2uPd5q7
=YFFE
-----END PGP SIGNATURE-----