[Freeipa-devel] [PATCH] fixes and corrections for locale

Simo Sorce ssorce at redhat.com
Thu Apr 9 19:28:13 UTC 2009


On Wed, 2009-04-08 at 20:48 -0400, Dmitri Pal wrote:
> I am resubmitting the patch with additional patch that corrects Simo 
> concerns.
> a) do-while
> b) checking for decimal point symbol.
> I did not quite figure out how to create one patch instead of original 
> one and a correction to it. Hint will be appreciated.

There a re a couple of ways.
If the patch you want to change is the last one committed, you can add
the --amend switch to git commit. This will add the changes you are
committing to the last existing commit instead of creating a new one.

Another way is of course to git reset --soft HEAD^, so that you uncommit
the previous commit, then make a new commit including all changes.

Another way is to 'squash' the second patch into the first doing a git
rebase -i

> But I will not be available tomorrow so I did not want to block you.

Ok I'll merge these into a single patch and push them.

> I also checked code for the type casting of "const char *" to "char *" 
> in my recent patch and did not see a place that Simo was concerned about 
> so I do not know what to change  if anything.

I'll check and fix them in the new merge patch and will push the fix
together with the rest.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list