[Freeipa-devel] [PATCH][SSSD] Monitor configuration changes

[Stephen Gallagher]

Stephen Gallagher wrote:
> Stephen Gallagher wrote:
>> Simo Sorce wrote:
>>> On Wed, 2009-04-08 at 17:17 -0400, Stephen Gallagher wrote:
>>>> First set of changes to the monitor to support live configuration
>>>> reloads.
>>>>
>>>> Patch 0001: Change the build system so that the monitor's service pipe
>>>> is fixed at compile-time.
>>> ack and pushed 
>>>
>>>> Patch 0002: Enable the monitor to handle SIGHUP to start, stop and
>>>> update running children without always restarting them. Note,
>>>> configuration changes where the binary path or provider type has
>>>> changed
>>>> will still necessitate a child process restart.
>>> nack, do not kill and free services in service_signal_reload()
>>>
>>> The rest is fine (see minor nitpicking comments on IRC)
>>>
>>>> The monitor will signal the children through the SBUS to shut down
>>>> gracefully, but if they do not yet implement it or are unable to do so
>>>> within the specified timeout, the monitor will kill them with a POSIX
>>>> signal. Whenever the monitor's configuration changes, it will send a
>>>> message to all registered children to reread their configuration as
>>>> well. At the moment it doesn't care whether they succeed at this or
>>>> not
>>>> (TODO)
>>> Simo.
>>>
>> Attaching two versions of this patch. Since the original was so large,
>> I'm also attaching a diff of just the changes since code review. The
>> smaller patch is not intended to go into the repo. It has been merged
>> into the larger patch.
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> Two additional changes spotted during code review:
> 1) shutdown_reply() will now call monitor_kill_service if the impossible
> situation happens where the reply handler is called without a valid
> reply object.
> 
> 2) The addition of the service destructor was fundamentally flawed. It
> has been fixed so that it will now DLIST_REMOVE() from
> svc->mt_ctx->svc_list instead of adding a new "first" attribute.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Missed one other small fix. Changed return of delist_service to return 0
rather than EOK (for clarity).

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Redesign-the-the-monitor-s-configuration-to-enable-l.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090410/dbda0951/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090410/dbda0951/attachment.sig>