[Freeipa-devel] [PATCH] Fix filter generator in ldapapi. Shouldn't produce invalid filters anymore.

[Rob Crittenden]

Pavel Zuna wrote:
> Rob Crittenden wrote:
>> Pavel Zuna wrote:
>>> ldap search method was generating invalid filters when the list of 
>>> search keywords was empty making it impossible to search by 
>>> objectClass or base alone.
>>>
>>> Pavel
>>
>> Before I ack, under what conditions are there no search keywords?
>>
>> rob
> Some cases I can think of now:
> 
> 1) We want to specify our own filter using the sfilter keyword argument 
> without any additional filters generated by the ldapapi.
> 
> 2) Searching by objectclass only like this:
> 
> search_kw['objectlass'] = 'posixUser'  # generates invalid filter
> 
> (There was a workaround for this though: search_kw['objectClass'] = 
> 'posixUser')
> 
> 3) Searching by base/scope only, for example searching for all direct 
> subentries of DN:
> 
> search_kw['base'] = DN
> search_kw['scope'] = 'one'
> 
> Pavel

Ok, works for me.

Ack and pushed to master

rob