[Freeipa-devel] [PATCH] Make LDAP entry output slightly nicer, don't print u's in front of unicode strings etc.

[Rob Crittenden]

Pavel Zuna wrote:
> Rob Crittenden wrote:
>> Pavel Zuna wrote:
>>> Minor change to the way textui.print_entry works. The old version was 
>>> printing the python representation of values, which looks weird for 
>>> users not familiar with python, especially with unicode strings 
>>> having the letter 'u' prepended to them. I think it's a bit nicer 
>>> this way and no value is lost.
>>>
>>> Pavel
>>>
>>
>> Partial ack.
>>
>> This is a good addition but at least the env plugin should continue 
>> using repr.
>>
>> We really need both capabilities. How about adding either a second 
>> function (or perhaps a flag) to do the repr() version and change the 
>> env plugin to use that.
>>
>> Can you resubmit with these changes?
>>
>> rob
> The env plugin uses textui.print_keyval that uses repr(), although not 
> explicitly.
> 
> print '%s = %r' % (key, value)  # same as: print '%s = %s' % (key, 
> repr(value))
> 
> Pavel

Ah, right you are.

Ack and pushed to master.

rob