[Freeipa-devel] [PATCH] Invoke shadow-utils from sss_tools for legacy domains

Jakub Hrozek jhrozek at redhat.com
Mon Apr 27 12:50:20 UTC 2009


On Mon, 2009-04-27 at 07:24 -0400, Stephen Gallagher wrote:
> Nack.
> 
> Shadow utils path needs to be a configure option, since it may not be
> in
> sbindir on all platforms.
> 
> In is_domain_local_legacy(), you check twice for
> strcasecmp(dom->provider, "proxy"). The second one (ANDed with the
> check
> for "files") is completely redundant, because it's sitting within the
> block from the previous check, and dom has not changed.

Thank you, new patch attached.

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Invoke-shadow-utils-in-sss_-tools.patch
Type: text/x-patch
Size: 27499 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090427/528e975b/attachment.bin>


More information about the Freeipa-devel mailing list