[Freeipa-devel] [PATCHES] start/stop related fixes

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Hrozek wrote:
> Hi,
> attached are four small fixes (separately b/c they fix different issues)
> that deal with start and stop sequence of sssd.
> 
> The first one reads the config file before calling server_setup() which
> daemonizes, so errors in config file are caught before becoming a
> daemon. Would it make sense to do as many configuration steps (from
> monitor_process_init() - like actually initializing confdb etc.) as
> possible before the daemonization?

Due to a bug in D-BUS, we cannot set up any portion of the SBUS
functionality until after the daemonization, or it will be torn down
when we fork and kill the original.

> 
> Fix initscript return codes is pretty straightforward - just return
> correct values in initscript functions. These two patches should address
> ticket #28.
> 
> The third one redirects stderr when starting sssd to a temporary logfile
> and only prints it when something fails during the startup. This should
> address ticket #27.

Why are you doing rm -f $LOGFILE at the end of start()? Won't you erase
any startup error messages?

> The last one removes the pid file on quitting sssd, right now the pid
> file is left in /var/run after sssd finished which doesn't seem right.
> Related to this - should sssd be a single-instance daemon? If so,
> there's another bug in pidfile() - a second instance of sssd that's ran
> overwrites the pid file. 
> 

Yes, SSSD MUST be single-instance. Please fix that and roll it into this
patch.

> Jakub
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkn5y6cACgkQeiVVYja6o6OmJgCaAuWjHWwKUy0LaPx9nfz/NgS8
kJgAoJBw5NZkhMu3kMrlzJbFvDzSXNzg
=QD9i
-----END PGP SIGNATURE-----