[Freeipa-devel] [PATCHES] start/stop related fixes

[Simo Sorce]

On Thu, 2009-04-30 at 13:11 -0400, Stephen Gallagher wrote:
> >> Why are you doing rm -f $LOGFILE at the end of start()? Won't you
> >> erase
> >> any startup error messages?
> >>
> > 
> > Yes, but after printing them to stderr if needed. The logfile is
> > temporary for the startup.
> > 
> > The intent was to save stderr to a temporary logfile, check if sssd
> > started correctly, if so, don't show the stderr output (as it
> contains
> > the "Unable to register control with rootdse!" messages), if it
> failed
> > to start, print the error messages.
> > 
> 
> Ok, I think I misread it.
> In that case, it's fine.

No, not really, rm will only remove the file from the directory, but the
file will exist until it is closed. If sssd starts spitting a consistent
amount of data to stderr it will go into that file and the admin will
not see it growing and eating disk space.

I think we should really just redirect to /dev/null, if someone is
interested in debug output then he can just run it manually or change
the init file.

IMO.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York