[Freeipa-devel] [PATCHES] Support for RPM generation in SSSD

[Rob Crittenden]

Stephen Gallagher wrote:
> These three patches provide beginning support for generating RPMs from
> the SSSD source tree. They are based on the Samba/LDB spec files. I also
> had to make a few modifications to our build tree to allow this.
> 

With my rpm-reviewer hat on:

- Just a nit, but you have a variable named 'tarball_name' that doesn't 
contain the .tar extension :-) Does it really provide clarity to have 
these separate variables?
- You probably don't need explicit library Requires: libtalloc, 
libtevent, etc. rpm should add those.
- I don't think you need/want separate Version/Release for subpackages.
- For the infopipe package do you need the -n 'sssd-' part?
- In %setup it looks like tarball_name just mirrors other variables. I 
suspect that plaint setup -q would work.
- For all the %post/%postun I think it is recommended to have that on a 
single like like: % post -p /sbin/ldconfig
- You should add: Requires(post): /sbin/ldconfig
- For the configure call I'd replace /etc with %{_sysconfdir} and /usr 
with %{_usr}
- There is no changelog

For the other patches, should there be a distclean target at the top-level?

Otherwise the code looks ok to me but I'm not that familiar with SSSD.

rob