[Freeipa-devel] [PATCH][SSSD] Fix serious memory allocation bug

[Simo Sorce]

On Mon, 2009-02-23 at 15:50 -0500, Stephen Gallagher wrote:
> 
> 
> Fixing serious memory allocation bug in sbus_message_handler.
> dbus_message_append_args() adds a reference to memory that is not
> copied
> to the outgoing message until dbus_connection_send() is called. Since
> we
> compile our reply messages in functions and then return the reply, we
> need a mechanism for deleting allocated memory after invoking
> dbus_connection_send. I have changed the arguments to
> sbus_msg_handler_fn so that it takes a talloc ctx containing the
> sbus_message_handler_ctx and a pointer to a reply object. We can now
> allocate memory as a child of the reply context and free it after
> calling dbus_connection_send.
> 
> SSSD developers take note of the parameter change for sbus_method
> handlers. I have migrated all of the existing functions.

ack and pushing

-- 
Simo Sorce * Red Hat, Inc * New York