[Freeipa-devel] Re: [PATCH 0/1] add pam support for sssd

[Simo Sorce]

On Wed, 2009-02-25 at 09:51 +0100, Sumit Bose wrote:
> 
> I have applied the patches to the current master
> (4c6c0f77a505b6b0790cfa8eedd3133abebd4edb) and they work as expected
> against a LDAP server. From my point of view they can be pushed.

ok pushed
please address the memory issues as well.
(Ah also please check the coding style guide, from freeipa, sometimes I
found some style issues :-)

ie:
dont't:
 if ( foo == NULL ) {
but:
 if (foo == NULL) {
or:
 if (!foo) {


also when you create a function make sure the opening { is on a new
line.

ie:
don't:
 void foo(bar) {
but:
 void foo(bar)
 {



Simo.

-- 
Simo Sorce * Red Hat, Inc * New York