[Freeipa-devel] [PATCH][SSSD] Fix invalid pointer in ldb_debug_message

[Stephen Gallagher]

On 06/04/2009 02:12 PM, Simo Sorce wrote:
> On Thu, 2009-06-04 at 13:39 -0400, Stephen Gallagher wrote:
>> -    DEBUG(loglevel, (fmt, ap));
>> +    vasprintf(&message, fmt, ap);''
> 
> NACK, you don't chek vasprintf return value or if message != NULL
> 
>> +    va_end(ap);
> 
> NACK, the caller does this.
> 
> Simo.
> 

See attached new version (which also corrects the same vasprintf() issue
in debug_fn();



-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-invalid-pointer-error-in-ldb_debug_messages.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090604/a65df593/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090604/a65df593/attachment.p7s>