[Freeipa-devel] Re: [PATCHES] Add new set of base classes for plugins using LDAP.

[Rob Crittenden]

Pavel Zuna wrote:
> I rewritten the patches I posted last week according to the feedback I got.
> 
> The changes are:
> - all the functionality specific to LDAP plugin base classes has been 
> removed from Object and crud base classes.
> - there is now 2 types of callbacks: pre_callbacks (called before 
> passing data to python-ldap throught the LDAP backend) and 
> post_callbacks (called after getting output from python-ldap)
> - some bug fixes
> 
> Patch 0006: Modify PluginProxy to use __public__ defined in derived 
> classes instead of base classes.

ack

> 
> Patch 0007: Add 'parent_key' kwarg in Param class.

ack, still not super happy with the variable name but since I can't come 
up with anything better we'll stick with it :-)

> 
> Patch 0008: Make get_dn parameter list more generic. Fix Attribute name 
> regex.
> 
> The old name regex made it impossible to have Attribute instances with 
> names composed of more than two words separated by underscores.

ack

> 
> Patch 0009: Generate crud.Search arguments with get_args.
> 
> (This might not be required, but I wanted to make sure arguments are 
> generated properly in subclasses.)

ack

> 
> (Patch 0010 is in a separate e-mail at Martin's request.)
> 
> Patch 0011: Add new set of base classes for plugins using LDAP.

nack. The reason that 2 values are returned in a list via the search in 
the current backend (and v1) is so you can tell whether a search failed 
because it exceeded either the size or time limits. We called this a 
"truncated" search. We return as much as we can though. I think we 
should retain this capability, even if we do it slightly differently.

The 4 patches I acked I've pushed to master.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090610/6d606f2b/attachment.bin>