[Freeipa-devel] [PATCHES][SSSD] Patches for supporting non-Fedora builds

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/18/2009 05:07 AM, Sumit Bose wrote:
> Am 17.06.2009 20:05, schrieb Stephen Gallagher:
>> 0001: Remove -Werror from the build. This can be added manually during
>> development, but it causes builds to fail on warnings when running older
>> versions of GCC. These warnings will be addressed separately.
> 
> ACK
> 
>> 0002: Add configure check for libpcre > 7. Currently we are using some
>> 7+ features. This causes the build to fail on RHEL 5, for example.
>>
> 
> Wouldn't it be more flexible to test for the feature?

I would, but I'm not sure how to. The specific error that fails on RHEL5
is looking for a particular macro definition that is only available with
version 7 on (PCRE_DUPNAMES). It's not a function call, so AC_CHECK_LIBS
can't check it. Testing for the version was the only way I was sure it
would work.

> 
> bye,
> Sumit


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAko6JzkACgkQeiVVYja6o6OYAwCgnLG34pZ4D1u+SXJeeTIUyK1M
k8oAoKJh7uqqKkXKAji0MH7j21A4ICL6
=OZII
-----END PGP SIGNATURE-----