[Freeipa-devel] Re: [PATCH] Add automount plugin port to new LDAP backend.

[Pavel Zůna]

Rob Crittenden wrote:
> Pavel Zuna wrote:
>> Patch 0013: Add automount plugin port to new LDAP backend.
>>
>> Pavel
> 
> There are some problems with this port from the old mechanism.
> 
> I'm ok with renaming the functions I suppose, we'll have to see through 
> usage which one is better.
Renaming was necessary, because Method to Object association is created 
according to plugin names. If we want an -add method for the 
automountkey object, its name has to start with 'automountkey'.

> But it doesn't seem to actually be working. automount2-tofiles doesn't 
> work at all and automount2-create-indirect doesn't create the maps 
> properly.
Yeah, looks like I didn't understand correctly how automount entries are 
organized in LDAP.

> I was originally a little worried that when deleting a map you were 
> removing the connection to the parent in the pre callback but it looks 
> like the keys aren't being removed either. I think the parent connection 
> should be removed after the entry is removed.
> 
> Can you take another look?
> 
> rob
I did an updated version. I also renamed the -create methods to -add, 
but forgot about -delete before making the commit. I will rename those 
later, the plugin name had to stay suffixed with 2 for now anyway.

Pavel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-automount-plugin-port-to-new-LDAP-backend.patch
Type: application/mbox
Size: 9413 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090618/e7c52f2a/attachment.mbox>