[Freeipa-devel] [PATCH] Gettextize the sss_ tools

Simo Sorce ssorce at redhat.com
Fri Jun 19 18:59:02 UTC 2009


On Fri, 2009-06-19 at 15:55 +0200, Jakub Hrozek wrote:
> 
> 
> The attached patch converts the static strings in the tools into
> gettext
> _("strings").

Looking at this patch I realize that we used DEBUG() improperly here.
DEBUG() shouldn't be used to return errors, but to aid in debugging.
So we should probably split the DEBUG statements used here in 2.

1. A set of PRINT() statements for messages intended to be returned to
users, these messages will be localized, and localization should be part
of the macro itself. Also any time more than 2 parameters are required,
we should use positionals because the position of an expanded parameter
may vary depending on the language.

2. A set of DEBUG() statements for messages intended to be seen only
during debugging. These *should not* be translated.


Comments ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list