[Freeipa-devel] [PATCH] replaced pure ldb calls with sysdb calls

[Sumit Bose]

Simo Sorce schrieb:
> On Tue, 2009-03-03 at 15:33 +0100, Sumit Bose wrote:
>> Hi,
>>
>> please find enclosed a patch that will remove the synchronous ldb
>> calls
>> and replace them with asynchronous sysdb calls.
> 
> Some more comments:
> 
> - in set_user_attr_req() you must call sysdb_transaction_done() with the
> error so that the transaction is canceled in case of failure.
> Otherwise all your transactions will be stuck as they are serialized and
> you didn't close this one. Probably you didn't see this because you
> closed sysdb at each request (another reason not to do that).
> 
> - FWIW, while the macros allows you to reduce the lines of code, IMO
> they makes the check less comprehensible, at least to me (I had to look
> it up a few time to get what they did). It also prevents you from
> controlling the debug level for each message and sometimes I think it
> means just too many debug messages too.
> But this may be just personal preference.
> 
> Simo.
> 
I think the following patch addresses all discussed issues, except the
DEBUG macros.

bye,
Sumit
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-replaced-pure-ldb-calls-with-sysdb-calls.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090303/eb77e325/attachment.ksh>