[Freeipa-devel] [PATCH x2] Two patches to improve sysdb and simplify LOCAL pam

Simo Sorce ssorce at redhat.com
Wed Mar 4 15:50:29 UTC 2009


I think the first one is a no brainer.

I did the second as part of a second review while testing the code.
In the pam responder I changed 2 things for the better (imo).

1. use only one context for everything and just free it when all is
done. The callback context was really unnecessary and added just more
code. Also by keeping one context we do not have to remember when to
free what if later on we change the code. As we know everything will be
freed when the operation is completed and at the same time everything is
available until the operation is completed.

There are other modification I'd like to make but I want to discuss them
firs on IRC.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improve-sysdb.patch
Type: text/x-patch
Size: 7364 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090304/2687f687/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Simplify-some-aspects-of-pam_LOCAL_domain.patch
Type: text/x-patch
Size: 19329 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090304/2687f687/attachment-0001.bin>


More information about the Freeipa-devel mailing list