[Freeipa-devel] [PATCH x2] Two patches to improve sysdb and simplify LOCAL pam

Simo Sorce ssorce at redhat.com
Wed Mar 4 16:24:42 UTC 2009


On Wed, 2009-03-04 at 17:17 +0100, Sumit Bose wrote:
> Simo Sorce schrieb:
> > I think the first one is a no brainer.
> > 
> > I did the second as part of a second review while testing the code.
> > In the pam responder I changed 2 things for the better (imo).
> > 
> > 1. use only one context for everything and just free it when all is
> > done. The callback context was really unnecessary and added just more
> > code. Also by keeping one context we do not have to remember when to
> > free what if later on we change the code. As we know everything will be
> > freed when the operation is completed and at the same time everything is
> > available until the operation is completed.
> > 
> > There are other modification I'd like to make but I want to discuss them
> > firs on IRC.

> ack

pushed

(and pushed also a COPYING file with the license in the root directory)

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list