[Freeipa-devel] [PATCH] added PAM default configuration to confdb_init_db

[Sumit Bose]

Stephen Gallagher schrieb:
> Stephen Gallagher wrote:
>> Stephen Gallagher wrote:
>>> Sumit Bose wrote:
>>>> see $subject.
>>>> bye,
>>>> Sumit
>>>> ------------------------------------------------------------------------
>>>> _______________________________________________
>>>> Freeipa-devel mailing list
>>>> Freeipa-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>> I overlooked this when I wrote that function in the first place, but
>>> could you do a NULL check on all of the val[0] assignments that call
>>> talloc_asprintf()? We should be handling out-of-memory properly. Passing
>>> a NULL value of val[0] *will* cause a segfault in confdb_add_param().
> 
>> I take that back, it won't cause a segfault, but it still would cause
>> unexpected behavior (falsely reporting success, since NULL is the loop
>> terminator for the values).
> 
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> 
> 
> Also, I have one more change for you to add into the confdb_init_db()
> function:
> Please change the InfoPipe configuration to use "config/services/info"
> instead of "config/services/infp", as Simo and I decided on this
> earlier. There was a patch to fix this at some point, but I think it
> never got pushed.
> 
> Also, there's a typo in the confdb.ldif, the cn=infp line should also be
> cn=info.
> 
> Would you mind correcting these and rolling it into this patch?
>

patch with changes attached.

bye,
Sumit
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-added-PAM-default-configuration-to-confdb_init_db.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090306/152e5ed5/attachment.ksh>