[Freeipa-devel] [PATCH] cope with confdb sync calls to its ldb

Simo Sorce ssorce at redhat.com
Fri Mar 20 17:34:39 UTC 2009


On Thu, 2009-03-19 at 15:07 -0400, Stephen Gallagher wrote:
> Simo Sorce wrote:
> > On Thu, 2009-03-19 at 12:24 -0400, Stephen Gallagher wrote:
> >> Simo Sorce wrote:
> >>> Needed to avoid calling events from within a confdb call.
> >>> I do not expect this to impact any code because the confdb is tiny
> and
> >>> is mmaped so all reading operations should rarely cause any I/O
> and in
> >>> that case it is disk I/O on the local disk, so perfectly tolerable
> the
> >>> rare times that happens.
> >>>
> > 
> >> There's no longer a need to pass tevent_ctx() to confdb_init(). I
> >> suggest removing it for clarity.
> > 
> > I does not hurt anyway, and it may turn out to be useful again
> later, I
> > felt no need to change the interface (and all callers).
> > 
> > Simo.
> > 
> 
> I'm not a huge fan of useless parameters, but I'll let it slide.
> 
> Ack.

pushed

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list