[Freeipa-devel] [PATCH][SSSD] Clean up warnings in monitor.c

[Sumit Bose]

Stephen Gallagher schrieb:
> Updated patch, also cleaning up warning in confdb.c
> 
> On 05/11/2009 02:43 PM, Stephen Gallagher wrote:
>> GCC 4.4.0 reveals more warnings than previous versions.
>>
>> Clean up function prototype, return without value and pointer signedness
>> warnings.
>>

All changes make sense to me. Wouldn't it be nicer to have
"opt_config_file = talloc_strdup(NULL, CONFDB_DEFAULT_CONFIG_FILE);"
after server_setup? Then you can use main_ctx and do not have to create
a top level context for opt_config_file.

bye,
Sumit