[Freeipa-devel] [PATCH] Check for valid ID ranges and ID overlaps between domains

[Jakub Hrozek]

On Mon, 2009-05-11 at 13:23 -0400, Stephen Gallagher wrote:
> Nack. If a domain has an invalid range specified, it should be an
> error,
> not a warning. (e.g. id_min >= id_max, id_min or id_max < 0, etc.)
> 
> Also, I'd prefer if you used a variable name other than "first" for
> the
> outer loop. It gives the impression that you're always comparing
> against
> the first domain in the list.
> 

Another iteration attached. Returns EINVAL on invalid range, only prints
DEBUG(1,...) on overlap.

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-for-valid-ID-range-domains-overlap.patch
Type: text/x-patch
Size: 2018 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090514/e39c6bc2/attachment.bin>