[Freeipa-devel] [PATCH] Check for valid ID ranges and ID overlaps between domains

[Simo Sorce]

On Thu, 2009-05-14 at 14:50 +0200, Jakub Hrozek wrote:
> On Mon, 2009-05-11 at 13:23 -0400, Stephen Gallagher wrote:
> > Nack. If a domain has an invalid range specified, it should be an
> > error,
> > not a warning. (e.g. id_min >= id_max, id_min or id_max < 0, etc.)
> > 
> > Also, I'd prefer if you used a variable name other than "first" for
> > the
> > outer loop. It gives the impression that you're always comparing
> > against
> > the first domain in the list.
> > 
> 
> Another iteration attached. Returns EINVAL on invalid range, only prints
> DEBUG(1,...) on overlap.

Ack and pushed.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York