[Freeipa-devel] [PATCH] Make Data Provider a mandatory service

[Jakub Hrozek]

On Thu, 2009-05-28 at 07:44 -0400, Stephen Gallagher wrote:
> Please use strcasecmp() instead of strcmp() when searching for the
> services.
> 

done.

> Why are you realloc()-ing to i+2? i+1 is sufficient because you're
> replacing one spot already allocated.

Because i is not the number of strings, but rather index of the ending
NULL. The number of strings is i+1, so you need to realloc to i+2.

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-Data-Provider-a-mandatory-service.patch
Type: text/x-patch
Size: 1705 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090528/c091c5a5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090528/c091c5a5/attachment.sig>