[Freeipa-devel] [PATCH] Reading Int parameter class should respect radix prefix

Rob Crittenden rcritten at redhat.com
Thu Nov 19 19:59:57 UTC 2009


John Dennis wrote:
> Signed-off-by: John Dennis <jdennis at redhat.com>
> 
> Reading INT parameter class should respect radix prefix
> 
> The Int parameter class was not respecting any radix prefix (e.g. 0x) the user
> may have supplied. This patch implements _convert_scalar method for the Int
> class so that we can pass the special radix base of zero to the int constructor
> telling it to determine the radix from the prefix (if present).
> 
> ---
> 
>  ipalib/parameters.py |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)

The patch looks good. Can you provide some unit tests for it as well?

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091119/d1e7128b/attachment.bin>


More information about the Freeipa-devel mailing list